Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash part handling in enum sorting #2322

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Conversation

svaarala
Copy link
Owner

If enum temporary object has a hash part, in-place key sorting invalidates that hash. The fix is to rebuild the hash after sorting keys.

Fixes #2315.

If enum temporary object has a hash part, in-place key sorting
invalidates that hash.  The fix is to rebuild the hash after
sorting keys.
@svaarala svaarala added the bug label Jun 14, 2020
@svaarala svaarala added this to the v3.0.0 milestone Jun 14, 2020
@svaarala svaarala merged commit 798d3a2 into master Jun 14, 2020
@svaarala svaarala deleted the fix-enum-assert-gh2315 branch June 14, 2020 14:35
@svaarala svaarala mentioned this pull request Jun 14, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion Fail DUK_HOBJECT_E_GET_KEY(thr->heap, obj, i) != key in duk_hobject_props.c
1 participant